fix: Handle unblance table errors #801
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabo
reviewed
Jun 22, 2022
| hspan = cell.rowspan+k-i if cell.rowspan else minspan | ||
| if hspan > 0 and hspan < minspan: | ||
| minspan = hspan | ||
| if hasattr(cell, 'origin'): |
There was a problem hiding this comment.
I think you may be better off with a single check_cell_has_origin(cell) that dies on error and gets called in all these places.
Clearly, the need for this is a code smell.
See also #740 why this is solving the crash, but not all of the problem.
There was a problem hiding this comment.
I agree.
Might be worth looking to simplify the text table generation function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #740